Skip to content

chore(ci): remove conditionally based on deployments #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chanceaclark merged 1 commit into from
Jan 6, 2026
Merged

chore(ci): remove conditionally based on deployments #2807

chanceaclark merged 1 commit into from
Jan 6, 2026

Conversation

@chanceaclark
Copy link
Contributor

@chanceaclark chanceaclark commented Jan 5, 2026

What/Why?

We recently changed out deployments process to just one deployment target, thus we need to fix this CI action to account for it.

Testing

See CI.

Migration

N/A

@chanceaclark chanceaclark requested a review from a team as a code owner January 5, 2026 22:54
@vercel
Copy link

vercel bot commented Jan 5, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
catalyst Ready Ready Preview, Comment Jan 6, 2026 6:01pm

@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1511c20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

matthewvolk
matthewvolk approved these changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@matthewvolk matthewvolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you sir! I'm sure you already did but I double checked and couldn't find any more references to the project name in other workflow definition files

@chanceaclark chanceaclark force-pushed the chore/ci branch 3 times, most recently from 4a99be2 to ab1f6d9 Compare January 6, 2026 17:42
chanceaclark
chanceaclark commented Jan 6, 2026
View reviewed changes
Copy link
Contributor Author

@chanceaclark chanceaclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bigcommerce/team-catalyst need another review as I added some things.

.github/workflows/deploy.yml
Comment on lines +3 to +5
# secrets is for dependabot compatibility; prefer vars when available
VERCEL_ORG_ID: ${{ vars.VERCEL_ORG_ID != '' && vars.VERCEL_ORG_ID || secrets.VERCEL_ORG_ID }}
VERCEL_PROJECT_ID: ${{ vars.VERCEL_PROJECT_ID != '' && vars.VERCEL_PROJECT_ID || secrets.VERCEL_PROJECT_ID }}
Copy link
Contributor Author

@chanceaclark chanceaclark Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed the Github action wasn't deploying so changed this bit.

https://github.com/bigcommerce/catalyst/actions/runs/20732376914/job/59600526182

@chanceaclark chanceaclark added this pull request to the merge queue Jan 6, 2026
Merged via the queue into canary with commit da702cc Jan 6, 2026
8 checks passed
@chanceaclark chanceaclark deleted the chore/ci branch January 6, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorgemoya jorgemoya jorgemoya approved these changes

@matthewvolk matthewvolk Awaiting requested review from matthewvolk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chanceaclark @jorgemoya @matthewvolk