Skip to content

Conversation

@jorgemoya
Copy link
Contributor

What/Why?

SelectField was wrapping the Select component and causing double label/errors to be displayed. Deletes SelectField in favor of Select.

Added the workaround for the Radix issue to the Select component. Confirmed issue is not resolved.

Testing

Before:
image

After:
Screenshot 2026-01-07 at 12 12 10 PM

Migration

Remove SelectField and update components to use Select instead.

@jorgemoya jorgemoya requested a review from a team as a code owner January 7, 2026 18:13
@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2026

🦋 Changeset detected

Latest commit: ea5f21b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
catalyst Ready Ready Preview, Comment Jan 7, 2026 6:23pm

Copy link
Contributor

@chanceaclark chanceaclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully forget why we did it, but I remember having two "Selects" was intentional based on this PR #2326 Do we want to keep the two still or does it make sense to deduplicate based on that PR?

@jorgemoya
Copy link
Contributor Author

I fully forget why we did it, but I remember having two "Selects" was intentional based on this PR #2326 Do we want to keep the two still or does it make sense to deduplicate based on that PR?

Good callout @chanceaclark. I can't see a reason to separate these, maybe @hunterbecton can provide some context.

@jorgemoya
Copy link
Contributor Author

@chanceaclark I just noticed that at some point, the Select primitive component was modified to include a label, thus making the SelectField component obsolete.

We can keep just one (Select), or if we want to keep them separate, we need to make the Select component act as a true primitive with no label or error message logic.

@chanceaclark
Copy link
Contributor

I believe the SelectField contains the input, but I think there are some UI's like the PDP that utilize Select so moving over to utilizing an component with an input breaks when trying to add to the cart. I would double check though. @hunterbecton might know more though.

@jorgemoya
Copy link
Contributor Author

I believe the SelectField contains the input, but I think there are some UI's like the PDP that utilize Select so moving over to utilizing an component with an input breaks when trying to add to the cart. I would double check though. @hunterbecton might know more though.

SelectField contains Select, which is the original problem, since both included a label and errors.

With the removal of SelectField, I have tested all UIs that use the Select component and see no issues.

@hunterbecton
Copy link
Contributor

I believe the SelectField contains the input, but I think there are some UI's like the PDP that utilize Select so moving over to utilizing an component with an input breaks when trying to add to the cart. I would double check though. @hunterbecton might know more though.

SelectField contains Select, which is the original problem, since both included a label and errors.

With the removal of SelectField, I have tested all UIs that use the Select component and see no issues.

I don't recall why we have a separate SelectField, but I'm introducing a Field component in storefront-kit so we don't need one-off components that might need labels, input descriptions, or field errors.

Copy link
Contributor

@hunterbecton hunterbecton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see an issue with dropping the SelectField

@jorgemoya jorgemoya added this pull request to the merge queue Jan 7, 2026
Merged via the queue into canary with commit ea9d633 Jan 7, 2026
8 checks passed
@jorgemoya jorgemoya deleted the catalyst-1613-fix-duplicate-select branch January 7, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants