feat(payment): PAYPAL-6142 3DS not required create order #3109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-yaroslav-zhmutskyi
force-pushed
the
PAYPAL-6142
branch
from
7ff9c2b to
dc23a0b
Compare
bc-nick
reviewed
Jan 23, 2026
| authenticationState === TDSecureAuthenticationState.Succeeded && | ||
| [LiabilityShiftEnum.Yes, LiabilityShiftEnum.Possible].includes(liabilityShift) | ||
| ) { | ||
| return threeDSNonce; |
Contributor
There was a problem hiding this comment.
May I ask you to verify do we cover this case in test file? I may assume we can not
Contributor
Author
There was a problem hiding this comment.
We cover it with Possible value line 660 in test file
bc-yaroslav-zhmutskyi
force-pushed
the
PAYPAL-6142
branch
from
dc23a0b to
8e2b717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Create order in Fastlane payment process when 3DS is enabled (when required option is enabled) and PayPal / Bank does not request to show 3DS modal window (3DS is not eligible).
Rollout/Rollback
Revert
Testing
Unit
Manual
BCP Strong Customer Authentication Always
bcp_always.webm
BCP Strong Customer Authentication When Required
bcp_when_required.webm
PPCP Strong Customer Authentication Always
ppcp_always.webm
PPCP Strong Customer Authentication When Required
ppcp_fastlane_3ds.webm