Add 5-minute HTTP request stats grouped by origin IP#4
Conversation
|
@alowde - Code looks good to me. I'm not sure about the graphql issue the Sentry bot is pointing out though. Do you have any insight on that? |
|
@alowde - Also have you tried running this code in integration to check that there are no issues in a real environment https://launchbay.bigcommerce.net/projects/439/releases/integration To do that I think you will need to make a change on branch to fpm-cookery recipe here: https://github.com/bigcommerce/fpm-cookery/blob/master/cloudflare-exporter/recipe.rb to get a package on the apt repo in the lower envs Then update the container repo here https://github.com/bigcommerce/cloudflare-exporter/blob/main/config/install.sh to use that package And then you can do the deploy to integration linked above. Yeah this process sucks. We have a ticket to revamp this repo to move deployments to the standard container deployment strategy but so far it hasn't been prioritized. |
Pull Request Template
Description
Add new metrics for http requests to track performance of different origins (for example; different load balancers fronting the same app servers).
Adds:
These metrics use the AdaptiveHTTPGroup endpoint to get statistically significant sampled values and return values for a five-minute rolling period to avoid spikes caused by outliers that settle as all samples are aggregated in the Cloudflare metric pipeline.
Type of Change
Testing
make pr-testsand all tests passCode Quality
Before Submitting
Please ensure you have completed the following before submitting your PR:
# Run comprehensive tests make pr-testsIf the above command fails, please fix the issues before submitting your PR.
Additional Notes
Add any other context about the pull request here.