fix(storefront): SD-10795 Out_of_Stock banner is duplicated and overlaps Add_to_cart button on PDP#2601
Merged
bc-yevhenii-buliuk merged 1 commit intobigcommerce:masterfrom Jan 30, 2026
Conversation
0522638 to
8020ae4
Compare
rtalvarez
approved these changes
Jan 29, 2026
Contributor
|
@bc-yevhenii-buliuk Do you know why we have 2 different color for |
8020ae4 to
781ce62
Compare
…aps Add_to_cart button on PDP
781ce62 to
ba9152b
Compare
Contributor
Author
@jkanive As far as I know, it wasn't intentional - the variant-level banner was using a common alert style while product-level used error styling. I've unified them both to use error styling (red) for consistency. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes duplicate OOS banners and overlapping
Add to Cartbutton on PDP.Also it eliminates unnecessary AJAX on initial page load (addresses feedback from @bc-jz in PR #2198)
Additional info for visibility:
Problem:
product-level bannerfrom Handlebars +variant-level bannerfrom JS).Changes:
add-to-cart-wrappercomponent for correct layout positioning.showMessageBoxto avoid showing variant-level banner if product-level banner already exists.BCData.product_attributesfrom Stencil context, which now contains correct data after PR #46317.Requirements
Tickets / Documentation
Screenshots (if appropriate)
bug (track inventory on product level)
behavior after fix (track inventory on product level)
sd_10795_fix_inventory_on_product_level.mov
behavior after fix (track inventory on variant level)
sd_10795_fix_inventory_on_variant_level.mov.mov
unify out-of-stock banner styling for product and variant levels