feat: Add port option to stencil start #1250
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jairo-bc
reviewed
Jan 16, 2025
| } | ||
|
|
||
| // Use initial (before updates) port for BrowserSync | ||
| const browserSyncPort = initialStencilConfig.port; |
Contributor
There was a problem hiding this comment.
I think you can do instead
Suggested change
| const browserSyncPort = initialStencilConfig.port; | |
| const browserSyncPort = cliOptions.port || initialStencilConfig.port; |
Contributor
Author
There was a problem hiding this comment.
then we need do change
const updatedStencilConfig = this.updateStencilConfig(
{ initialStencilConfig, port: browserSyncPort},
storeInfoFromAPI,
);
jairo-bc
approved these changes
Apr 14, 2025
Contributor
|
@onur-o7 do you mind to rebase this one as well? |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds port option to stencil start.
Why?
Our company manages multiple dev servers that each run on a unique port using config.stencil.port. It has become challenging to work efficiently on localhost as we need to track different ports. This way, when closing a tab or browser, we won't have to copy the URL or restart the dev server with stencil start -o again.
cc @bigcommerce/storefront-team