Cancel button with inner content form submit properly #3368
+25
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another issue found with the change introduced in #3336 where a button inside a form that is htmx enabled and it has a element inside, when this inner element is clicked it does not prevent the button from submitting the form. We now use the target of the click event to find the element we need to check if it needs canceling and we already fixed this same issue with links containing inner elements but buttons can have the same issue it seems. Finding the closest button/input[type=submit] parent of the clicked target should always find the real button to check for preventing default action.
Corresponding issue:
#3366
Testing
Added a regression test for this issue and ran test suite
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded