Rework duck-typed parent into SlicedParentNode class #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main difference here is that
childNodesis now a live calculation, based on a bounding box defined by the originally-passed node's siblings. In other words, a parent node containing a live slice of its children.Also, the
SlicedParentNodename is better and more intention-revealing, I think.Lastly, it is now a JavaScript
class, which definitely goes against the overall C-ish style of Idiomorph. But since we're emulating a concrete aspect of the OOP DOM API, I think it makes sense.Fixes #124, and the return value issue in #126.