Fix persistence bug caused by untrustworthy HTMLFormElement.id getter#136
Merged
botandrose merged 3 commits intomainfrom Jul 27, 2025
Merged
Fix persistence bug caused by untrustworthy HTMLFormElement.id getter#136botandrose merged 3 commits intomainfrom
botandrose merged 3 commits intomainfrom
Conversation
…rmElement.id being untrustworthy. For more details: * #135 * https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement#issues_with_naming_elements
Closed
Collaborator
Author
|
Interestingly, it appears that the majority of the perf loss is simply in the function call itself... if I replace the implementation of the new Maybe a manual inline then? I don't love it, since we're accesing element ids all over the place... hmm. |
Collaborator
Author
|
Okay, I got something working here with inlining the function. Perf is mostly unaffected now, and the bug is fixed, but code readability suffers. Hmm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out we can't simply call
.idon element nodes, because that property is unreliable on<form>and<fieldset>elements. It could return the id of the node as expected, OR (problematically) a child element that has a name attribute ofid. The latter breaks persistence of the form element, which can have further consequences involving lost state.This PR has two commits:
I'm marking this PR as WIP in the hopes I can find a faster way to resolve this.
For more information, see: https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement#issues_with_naming_elements
Fixes #135