Skip to content

Conversation

geoffrey-eisenbarth
Copy link
Collaborator

Some small tweaks to get ready for 1.2.

@geoffrey-eisenbarth
Copy link
Collaborator Author

geoffrey-eisenbarth commented Aug 10, 2025

@dz4k two final things:

  1. When I deprecated --rhythm, I actually used rlh bc I got the vibe that --rhythm should only be defined on :root. But, maybe it's better to replace those all with lh unit instead?
  2. When I implemented colorways for buttons, I forgot that colorways kind of require explicit opt-in via .color and .bg. THe button impl doesn't require anything other than e.g. .ok / .info, etc. <select>, on the other hand allows for a toned down version with just .ok and a "fuller" version with .ok .bg .color. Is this inconsistency okay?

@geoffrey-eisenbarth geoffrey-eisenbarth added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 10, 2025
@geoffrey-eisenbarth geoffrey-eisenbarth added this to the 1.2.0 milestone Aug 10, 2025
@dz4k
Copy link
Collaborator

dz4k commented Aug 10, 2025

When I deprecated --rhythm, I actually used rlh bc I got the vibe that --rhythm should only be defined on :root. But, maybe it's better to replace those all with lh unit instead?

rlh is the right choice i think, because lh would scale with font size (e.g. on headings)

When I implemented colorways for buttons, I forgot that colorways kind of require explicit opt-in via .color and .bg. This is not the case for buttons (but, on the other hand, do require them to be "fully colorway'd". Is this inconsistency worth addressing in the css? I don't think there's anything wrong with that, .box also picks up colors automatically

@geoffrey-eisenbarth geoffrey-eisenbarth merged commit 4295d97 into bigskysoftware:dev Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants