Skip to content

FIX [11671] l10n_ve_accountant#690

Merged
miguel-binaural merged 1 commit into17.0from
17.0-fix-ti-#11671-addComputeFieldToWarningDiferent0
Mar 17, 2026
Merged

FIX [11671] l10n_ve_accountant#690
miguel-binaural merged 1 commit into17.0from
17.0-fix-ti-#11671-addComputeFieldToWarningDiferent0

Conversation

@HericeBinaural
Copy link

@HericeBinaural HericeBinaural commented Mar 16, 2026

Problema:
La alerta de balance alterno se mostraba de forma errónea cuando el saldo era 0 debido a imprecisiones de coma flotante en la evaluación del lado del cliente (XML).

Solución:
Se introduce el campo computado 'display_foreign_balance_warning' que utiliza la herramienta 'is_zero' de Odoo para validar el saldo con la precisión exacta de la moneda. Se actualiza la vista para depender de este nuevo campo.

Link: https://binaural.odoo.com/web#id=11671&cids=2&model=helpdesk.ticket&view_type=form Ticket de TRIAJE [x]

…do alterno

Problema:
La alerta de balance alterno se mostraba de forma errónea cuando el saldo era 0
debido a imprecisiones de coma flotante en la evaluación del lado del cliente (XML).

Solución:
Se introduce el campo computado 'display_foreign_balance_warning' que utiliza
la herramienta 'is_zero' de Odoo para validar el saldo con la precisión
exacta de la moneda. Se actualiza la vista para depender de este nuevo campo.

Link: https://binaural.odoo.com/web#id=11671&cids=2&model=helpdesk.ticket&view_type=form
Ticket de TRIAJE [x]
@HericeBinaural HericeBinaural requested a review from a team March 16, 2026 14:36
@HericeBinaural HericeBinaural self-assigned this Mar 16, 2026
@HericeBinaural HericeBinaural added the 🔄 En validación Etiqueta de estado de revisión: En revisión por el consultor funcional. label Mar 16, 2026
Copy link
Contributor

@binauralbot binauralbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Pruebas unitarias exitosas
Las pruebas unitarias se ejecutaron correctamente en el flujo de trabajo de CI/CD.

📋 Resumen de ejecución

  • Action: Run Tests from Pull Request
  • Run: Id: 23149202378

🧪 Resultado
Todas las pruebas unitarias pasaron sin errores. El código cumple con los criterios definidos para esta etapa del pipeline.

📋 Logs de ejecución:

No log file available.

{
  "all_tests_passed": true,
  "has_no_module_to_test": false,
  "test_results": [
    {
      "executed": 6,
      "passed": 6,
      "failed": 0,
      "errors": 0,
      "details": {
        "failures_count": 0,
        "errors_count": 0,
        "testsRun": 6,
        "skipped": 0,
        "tb_locals": false,
        "time_start": null,
        "queries_start": null,
        "_soft_fail": false,
        "had_failure": false,
        "stats": {
          "odoo.addons.l10n_ve_accountant.tests.test_account_move_rate.TestAccountMoveRate.setUpClass": [
            0.0003666877746582031,
            0
          ],
          "odoo.addons.l10n_ve_accountant.tests.test_account_move_rate.TestAccountMoveRate.test_foreign_rate_decimal_precision": [
            0.014015674591064453,
            33
          ],
          "odoo.addons.l10n_ve_accountant.tests.test_account_move_rate.TestAccountMoveRate.tearDownClass": [
            0.09778213500976562,
            4
          ],
          "odoo.addons.l10n_ve_accountant.tests.test_accountant.TestAccountant.setUpClass": [
            0.0002624988555908203,
            0
          ],
          "odoo.addons.l10n_ve_accountant.tests.test_accountant.TestAccountant.test_get_journal_income_account_fallback": [
            0.1890101432800293,
            230
          ],
          "odoo.addons.l10n_ve_accountant.tests.test_accountant.TestAccountant.test_no_update_when_missing_income_accounts": [
            0.3419792652130127,
            345
          ],
          "odoo.addons.l10n_ve_accountant.tests.test_accountant.TestAccountant.test_update_only_lines_using_old_journal_account": [
            0.4108450412750244,
            401
          ],
          "odoo.addons.l10n_ve_accountant.tests.test_accountant.TestAccountant.tearDownClass": [
            0.0037229061126708984,
            0
          ],
          "odoo.addons.l10n_ve_accountant.tests.test_form_account_move.TestFormAccountMove.setUpClass": [
            0.00025272369384765625,
            0
          ],
          "odoo.addons.l10n_ve_accountant.tests.test_form_account_move.TestFormAccountMove.test_foreign_rate_editable_only_on_in_invoice": [
            0.07011294364929199,
            102
          ],
          "odoo.addons.l10n_ve_accountant.tests.test_form_account_move.TestFormAccountMove.test_foreign_rate_editable_only_on_in_invoice_case_customer": [
            0.03964114189147949,
            37
          ],
          "odoo.addons.l10n_ve_accountant.tests.test_form_account_move.TestFormAccountMove.tearDownClass": [
            0.004309654235839844,
            0
          ]
        },
        "global_report": null,
        "shouldStop": false,
        "list_module_names": [
          "l10n_ve_accountant"
        ],
        "test_tags": "/l10n_ve_accountant",
        "dbname": "TESTING_INTEGRATION"
      },
      "tests_failed": false,
      "db_name": "TESTING_INTEGRATION",
      "output_local_path": "/home/runner/work/odoo-venezuela/odoo-venezuela/cicd-tool/_bincli_fork/chcli/data/devops/test_output_TESTING_INTEGRATION.log",
      "logs_uploaded_to_s3": true,
      "logs_s3_file_link": "https://sfo3.digitaloceanspaces.com/binauralbot/logs/core_review_odoo_test_logs/20260316T144204Z_test_output_TESTING_INTEGRATION.log?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=DO8014K4MZYGN83T7EAV%2F20260316%2Fsfo3%2Fs3%2Faws4_request&X-Amz-Date=20260316T144204Z&X-Amz-Expires=604800&X-Amz-SignedHeaders=host&X-Amz-Signature=80896877d0eb2c1ec8915c1dbcdd28a70b287ecac0e0c7530c7104cf81431062"
    }
  ],
  "mode": "integration",
  "modules_tested": [
    "l10n_ve_accountant"
  ],
  "odoo_version": "17.0",
  "pull_request_url": "https://github.com/binaural-dev/odoo-venezuela/pull/690",
  "pull_request_info": [],
  "mount": true,
  "logs_s3_file_links": {
    "TESTING_INTEGRATION": "https://sfo3.digitaloceanspaces.com/binauralbot/logs/core_review_odoo_test_logs/20260316T144204Z_test_output_TESTING_INTEGRATION.log?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=DO8014K4MZYGN83T7EAV%2F20260316%2Fsfo3%2Fs3%2Faws4_request&X-Amz-Date=20260316T144204Z&X-Amz-Expires=604800&X-Amz-SignedHeaders=host&X-Amz-Signature=80896877d0eb2c1ec8915c1dbcdd28a70b287ecac0e0c7530c7104cf81431062"
  },
  "extra_repositories_added": [
    {
      "url": "https://github.com/binaural-dev/enterprise.git",
      "branch": "17.0"
    }
  ]
}

📋 Logs de ejecución:

@HericeBinaural HericeBinaural added 17.0 Etiqueta de versión ✅ Validado Etiqueta de estado de revisión: Aprobado por consultoría funcional. and removed 🔄 En validación Etiqueta de estado de revisión: En revisión por el consultor funcional. labels Mar 16, 2026
@HericeBinaural HericeBinaural changed the title FIX [11671] l10n_ve_accountant: corregir visibilidad de alerta de sal… FIX [11671] l10n_ve_accountant: Mar 16, 2026
@HericeBinaural HericeBinaural changed the title FIX [11671] l10n_ve_accountant: FIX [11671] l10n_ve_accountant Mar 16, 2026
@miguel-binaural miguel-binaural merged commit f7c648b into 17.0 Mar 17, 2026
1 check passed
@miguel-binaural miguel-binaural deleted the 17.0-fix-ti-#11671-addComputeFieldToWarningDiferent0 branch March 17, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

17.0 Etiqueta de versión ✅ Validado Etiqueta de estado de revisión: Aprobado por consultoría funcional.

Development

Successfully merging this pull request may close these issues.

3 participants