Implement ListSessions of BGP API#271
Open
sebageek wants to merge 2 commits intobio-routing:masterfrom
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
==========================================
+ Coverage 59.25% 59.60% +0.35%
==========================================
Files 137 137
Lines 7542 7588 +46
==========================================
+ Hits 4469 4523 +54
+ Misses 2892 2882 -10
- Partials 181 183 +2
Continue to review full report at Codecov.
|
Contributor
Author
|
From a quick look it should also be easy to get RoutesImported and RoutesExported from the metrics service. I'll add this to this PR tomorrow. |
7f74a99 to
a1a2d12
Compare
a1a2d12 to
c866150
Compare
flaps + routes imported in the stats are still missing.
c866150 to
855dbd4
Compare
Contributor
Author
|
I added some stuff. The session API now has a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VRF filtering and some session stats are still missing here, but listing
sessions does work.
I'm not 100% on what I should fill in into the SessionStat, that's why I only filled them partly.