Open
Conversation
korikuzma
reviewed
Feb 26, 2026
Contributor
There was a problem hiding this comment.
@ehclark FYI wanted to let you know about this change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #295 , #150 (I think)
Implement keyset pagination for the search endpoint. The storage class's
search_alleles()method now takes page size and cursor parameters, and returns a simple container around a set of results and the next cursor. The/searchendpoint similarly takes page size and cursor parameters. Behavior should reflect pretty straightforward keyset/cursor based pagination.Remove result size limit from get_objects because that's naturally limited by the # of IDs given.