Close #193, #194: Fix assert messages in gbseq.py

Author: Reece Hart

pyproject.toml

@@ -201,8 +201,6 @@ select = [
   "A001", # Variable `id` is shadowing a Python builtin
   "A002", # Function argument `id` is shadowing a Python builtin
   "B006", # Do not use mutable data structures for argument defaults
-  "F522", # `.format` call has unused named argument(s): n
-  "F524", # `.format` call is missing argument(s) for placeholder(s): n=n
   "F821", # Undefined name `pas`
   "G003", # Logging statement uses `+`
   "G004", # Logging statement uses f-string

src/biocommons/eutils/_internal/xmlfacades/gbseq.py

@@ -126,9 +126,7 @@ def __iter__(self):
     def cds(self):
         key = "CDS"
         nodes = self._get_nodes_with_key(key)
-        assert len(nodes) <= 1, "Node has {n=n} {key} features! (expected <= 1)".format(
-            n=len(nodes), key=key
-        )
+        assert len(nodes) == 1, f"Got n={len(nodes)} {key} features! (expected exactly 1)"
         return None if not nodes else GBFeatureCDS(nodes[0])
 
     @property
@@ -141,18 +139,14 @@ def exons(self):
     def gene(self):
         key = "gene"
         nodes = self._get_nodes_with_key(key)
-        assert len(nodes) <= 1, "Node has {n=n} {key} features! (expected <= 1)".format(
-            n=len(nodes), key=key
-        )
+        assert len(nodes) == 1, f"Got n={len(nodes)} {key} features! (expected exactly 1)"
         return None if not nodes else GBFeature(nodes[0])
 
     @property
     def source(self):
         key = "source"
         nodes = self._get_nodes_with_key(key)
-        assert len(nodes) == 1, "Got {n=n} {key} features! (expected exactly 1)".format(
-            n=len(nodes), key=key
-        )
+        assert len(nodes) == 1, f"Got n={len(nodes)} {key} features! (expected exactly 1)"
         return GBFeature(nodes[0])
 
     def _get_nodes_with_key(self, key):
@@ -193,11 +187,6 @@ def get_qualifiers(self, name):
 
     def get_qualifier(self, name):
         nodes = self.get_qualifiers(name)
-        assert len(nodes) <= 1, (
-            "Node has {n=n} {key} features! (expected <= 1 when using get_qualifier)".format(
-                n=len(nodes), key=name
-            )
-        )
         if not nodes:
             return None
         return self.get_qualifiers(name)[0]