Skip to content

cicd: remove pyright/mypy stuff #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsstevenson merged 1 commit into from
Aug 14, 2025
Merged

cicd: remove pyright/mypy stuff #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@
repos:
- repo: local
hooks:
- id: pyright
name: pyright
entry: pyright
language: system
types: [python]
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.4.4
hooks:
Expand Down
5 changes: 0 additions & 5 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ dependencies = ["coloredlogs ~= 15.0", "pyyaml ~= 6.0"]
dev = [
"build ~= 0.8",
"ipython ~= 8.4",
"mypy-extensions ~= 1.0",
Copy link
Contributor Author

@jsstevenson jsstevenson Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this was here? not to do a chesterton's fence violation but I think it can be removed regardless of whether we keep pyright

Copy link

@theferrit32 theferrit32 Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

load-bearing unimported dependency

Copy link

@theferrit32 theferrit32 Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably was used for IDE hinting for anyone who had mypy installed

"pre-commit ~= 3.4",
"pyright~=1.1",
"ruff == 0.4.4",
]
tests = [
Expand Down Expand Up @@ -104,9 +102,6 @@ exclude_lines = [
"if __name__ == .__main__.:",
]

[tool.pyright]
include = ["src", "tests"]

[tool.ruff]
src = ["src", "tests"]
line-length = 100
Expand Down
Loading