fix: Handle missing value in VCF INFO array fields#314
Merged
Conversation
Bump datafusion-bio-formats to pick up the fix for VCF INFO array fields (Number=R/A/., Type=Integer/Float/String) that panicked on `.` missing values within comma-separated elements (e.g. AD=.,15, AF=0.5,.). Previously this caused silent data truncation. Add regression tests verifying no row loss and correct null representation for all three array types (Integer, Float, String). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datafusion-bio-formatsgit rev to pick up the fix from datafusion-bio-formats#74Number=R,Number=A,Number=.) panicked on.(the standard VCF missing value) within comma-separated elements (e.g.AD=.,15,AF=0.5,.), causing silent data truncation (e.g. 5M rows → 229K rows with no error)Fixes #312
Test plan
test_info_array_missing_values_no_row_loss— all 4 rows returned (no silent data loss)test_info_array_missing_integer—.→nullin integer list arraystest_info_array_missing_float—.→nullin float list arraystest_info_array_missing_string—.→nullin string list arraystest_scan_vcf_info_array_missing_values— lazy scan path also works🤖 Generated with Claude Code