Skip to content

mininum tf1.13 #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2022
Merged

mininum tf1.13 #504

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38aeac5
mininum tf1.13
FynnBe Nov 3, 2022
96f1041
pin protobuf for default tf1 env
FynnBe Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/static_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,15 @@ def get_default_env(
if tensorflow_version is not None:
# tensorflow 1 is not available on conda, so we need to inject this as a pip dependency
if tensorflow_version.major == 1:
tensorflow_version = max(tensorflow_version, Version("1.13")) # tf <1.13 not available anymore
assert opset_version is None
assert pytorch_version is None
conda_env["dependencies"] = ["pip", "python >=3.7,<3.8"] # tf 1.15 not available for py>=3.8
# get bioimageio.core (and its dependencies) via pip as well to avoid conda/pip mix
# protobuf pin: tf 1 does not pin an upper limit for protobuf,
# but fails to load models saved with protobuf 3 when installing protobuf 4.
conda_env["dependencies"].append(
{"pip": [f"bioimageio.core", f"tensorflow {get_version_range(tensorflow_version)}"]}
{"pip": [f"bioimageio.core", f"tensorflow {get_version_range(tensorflow_version)}", "protobuf <4.0"]}
)
else: # use conda otherwise
conda_env["dependencies"].append(f"tensorflow {get_version_range(tensorflow_version)}")
Expand Down