admin/python-support-3.10+ #113
Conversation
BrianWhitneyAI
requested review from
SeanDuHare,
aswallace,
evamaxfield,
hughes036,
kmitcham,
toloudis and
yrkim98
|
I am pretty unsure about my update to the time series writer tests which is broken due to the dependency scramble. The original test is full of TODOs and caveats. I really just wrote a test to correctly assert whats happening currently but I think i am missing some of the complexity of the RGBA portion. Could use some input here. |
kmitcham
left a comment
kmitcham
left a comment
There was a problem hiding this comment.
Thanks! I should have caught some of these when moved it to 3.9, but others I had no idea existed.
|
pyproject.toml
Outdated
| "ome-types[lxml]>=0.4.0", | ||
| "ome-zarr>=0.6.1", | ||
| # Use ngff-zarr for Python 3.10 or lower and ome-zarr-models for Python 3.11 or higher. | ||
| 'ngff-zarr>=0.8.2,<0.9.1; python_version < "3.11"', |
There was a problem hiding this comment.
Why less than 0.9.1 still - I thought that was a 3.9 issue?
There was a problem hiding this comment.
Oh I didn't try it really. This is the version from before. The change here was mostly just the 'python_version < "3.11"''
|
Tests should pass after #116 is merged |
3 participants
Description
This PR does a few things all centered around updating our supported python versions to 3.10-3.13. It resolves #108, #104, #70, kind of resolves #10 maybe? And includes the changes from #105 and #80.
1.) Remove all past refrences to 3.9
2.) unpins
imageio[ffmpeg],numpy, andtifffile3.) Conditionally resolve 'ome_zarr_writer_2.py` dependencies to support all python versions
4.) define specific dependencies per python version
5.) update the time series writer tests which were broken and out of date. (this could probably be another PR but was trying to go green)