feature/parameterized-ome-tiff-writer-compression

[evamaxfield]

…ME TIFF Writer

Link to Relevant Issue

This pull request:

• Resolves [Feature Request] Image compression for ome.tiff files #87
• Resolves writer compression parameter #36

Description of Changes

This moves the hard coded compression setting in OmeTiffWriter to a parameter.

My only general discussion point before this gets merged is perhaps maybe we should just open up all tifffile kwargs like how we do with fs_kwargs?

[toloudis]

It says it resolves #36 but I think that one mentions both tiff and zarr. We need to at least have another open issue for zarr.

[evamaxfield]

@toloudis this PR has been updated to allow for all tifffile write kwargs to be passed. This should resolve the lack of compression args and generally just future proofing us a bit in the case people want to use other parameters.

Docstring includes custom compression example

[evamaxfield]

Quick note: seems like TIFF.COMPRESSION and the like have been deprecated since 2022 with preference for using tifffile.COMPRESSION etc. Do we want to make that change? I guess people could theoretically still be using tifffile 2021 versions but 🤷‍♀️

[toloudis]

I'm generally in favor of using current things but we might have to put a min value on our tifffile version?

[evamaxfield]

Ping on this. I don't think we need to change our minimum tifffile version for a bit.

Good to merge though? @toloudis @SeanLeRoy @BrianWhitneyAI

[toloudis]

Ping on this. I don't think we need to change our minimum tifffile version for a bit.

I thought you were going to do something to use the more current (post-2022) enum

[toloudis]

LGTM, thanks!