Skip to content

fix compilation error when RYML_NO_DEFAULT_CALLBACKS is defined#580

Merged
biojppm merged 1 commit intobiojppm:masterfrom
toge:fix-Callbacks-constructor
Mar 18, 2026
Merged

fix compilation error when RYML_NO_DEFAULT_CALLBACKS is defined#580
biojppm merged 1 commit intobiojppm:masterfrom
toge:fix-Callbacks-constructor

Conversation

@toge
Copy link
Copy Markdown
Contributor

@toge toge commented Mar 18, 2026

On 0.11.0, there are compilation errors:

src/c4/yml/common.cpp:136:19: error: ‘error_’ was not declared in this scope; did you mean ‘error_t’?
  136 |     m_error_basic(error_),
      |                   ^~~~~~
      |                   error_t
src/c4/yml/common.cpp:140:1: error: expected identifier before ‘{’ token
  140 | {
      | ^

This PR trys to fix these.

@biojppm
Copy link
Copy Markdown
Owner

biojppm commented Mar 18, 2026

Thanks for catching this. I see now that this case is not covered in the CI. I will follow up by adding those tests.

@biojppm biojppm merged commit bed66ab into biojppm:master Mar 18, 2026
250 of 256 checks passed
@toge
Copy link
Copy Markdown
Contributor Author

toge commented Mar 18, 2026

@biojppm
Thank you for quick action!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants