Skip to content

[ENH] UserInteraction can be extended by shift.#336

Merged
ales-erjavec merged 1 commit intobiolab:masterfrom
krystofair:krystofair/enh/shift-extends-useriteraction
Sep 26, 2025
Merged

[ENH] UserInteraction can be extended by shift.#336
ales-erjavec merged 1 commit intobiolab:masterfrom
krystofair:krystofair/enh/shift-extends-useriteraction

Conversation

@krystofair
Copy link
Contributor

Hello,

Like in description: Added flag for keep state across whole user interactions (in UserInteraction class) and implement it for ArrowAnnotation.

I Pull Request this feature, because I think this is some kind of intuitive and decrease mouse move when we repeat the same operation.

Of course shift is my personal choice, so if ctrl be better, the change is straightforward.

Introduced flag for keep state if shift was pressed on interaction ends.
Use this for arrow adnotation operation.
@krystofair krystofair changed the title UserInteraction can be extended by shift. [ENH] UserInteraction can be extended by shift. Sep 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.07%. Comparing base (005dc69) to head (ef53d8d).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
orangecanvas/document/schemeedit.py 66.66% 3 Missing ⚠️
orangecanvas/document/interactions.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
- Coverage   76.54%   76.07%   -0.48%     
==========================================
  Files         102      102              
  Lines       21316    21326      +10     
==========================================
- Hits        16317    16224      -93     
- Misses       4999     5102     +103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ales-erjavec ales-erjavec merged commit 840d84c into biolab:master Sep 26, 2025
21 checks passed
@krystofair krystofair deleted the krystofair/enh/shift-extends-useriteraction branch September 26, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants