Skip to content

Gradient descent small updates and fixes#19

Merged
ajdapretnar merged 5 commits intobiolab:masterfrom
PrimozGodec:gradient-descent
Sep 6, 2016
Merged

Gradient descent small updates and fixes#19
ajdapretnar merged 5 commits intobiolab:masterfrom
PrimozGodec:gradient-descent

Conversation

@PrimozGodec
Copy link
Collaborator

With this pull request we updated:

  • Modified gradient color to match to class.
  • Fixed save image functionality
  • Added some more information to the report.

@codecov-io
Copy link

codecov-io commented Aug 31, 2016

Current coverage is 98.24% (diff: 100%)

Merging #19 into master will increase coverage by 0.02%

@@             master        #19   diff @@
==========================================
  Files            13         13          
  Lines          1576       1595    +19   
  Methods           0          0          
  Messages          0          0          
  Branches        184        186     +2   
==========================================
+ Hits           1548       1567    +19   
  Misses           17         17          
  Partials         11         11          

Powered by Codecov. Last update 3c51358...32e53d0

@ajdapretnar
Copy link
Collaborator

I like the current improvements, however, I do have some comments.
Could reported parameters be in a new lines below the graph (as they are in the Scatter Plot widget)?
Also, is it possible to include X and Y parameters in the reported graph, rather than in the description below? I really wish to have the same graph in Report as we have it in Save Image (X and Y axis description, final cost and maybe even colors (but that's optional).

Everything else looks good to me!

@PrimozGodec
Copy link
Collaborator Author

It is fixed now via biolab/orange3#1541

@ajdapretnar
Copy link
Collaborator

I'll check once again and I'll merge.

@ajdapretnar ajdapretnar merged commit 3f82e7e into biolab:master Sep 6, 2016
@PrimozGodec PrimozGodec deleted the gradient-descent branch September 6, 2016 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants