Preprocess Text: Add Spacy POS tagger #1070
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The only thing left is to discuss the problem of additional dependencies in certain models (Chinese, Japanese, Russian and Ukrainian). Remove or somehow gracefully handle? |
Contributor
|
I get this, if the model is not installed. |
VesnaT
reviewed
Jul 19, 2024
| def __getitem__(self, language: str) -> str: | ||
| model = find_model(language) | ||
| if model not in self.installed_models: | ||
| download(model) |
Contributor
There was a problem hiding this comment.
self.installed_models should be updated at this point. If not the package keeps getting downloaded.
Collaborator
Author
|
So, the downloaded models are indeed packages. We have to warn the user that selecting a given language will install additional dependencies to the Orange environment (think about the wording). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Implements #596.
Description of changes
Add Spacy, first as a POS tagger because it is most sorely missed.
Later: implement Spacy for NER (also sorely missed). And for other NLP tasks (solo Spacy preprocessor).
Includes