Corpus: support relative file paths #1132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leskovecg
force-pushed
the
fix-relative-corpus-path
branch
from
e2547d9 to
c4552bd
Compare
ajdapretnar
reviewed
Sep 4, 2025
| out_corpus = self.get_output(self.widget.Outputs.matching_docs) | ||
| self.assertEqual(len(out_corpus), 1) | ||
| self.assertEqual(self.widget.n_matches, 7) | ||
| self.assertEqual(int(self.widget.n_matches), 7) |
Collaborator
There was a problem hiding this comment.
The PR should be rebased and then this test is no longer necessary.
leskovecg
force-pushed
the
fix-relative-corpus-path
branch
from
c4552bd to
a689b71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #534 – Corpus widget now supports saving and loading relative file paths.
Description of changes
This PR adds support for saving relative paths when a workflow is saved, and resolving them properly when the workflow is reloaded in a different directory.
fix_relative_pathandfix_absolute_pathutility functions.OWCorpusto save/load relative file paths using the current workflow location.test_relative_corpus_path_serializationto verify correct path resolution.Includes