Skip to content

[FIX] CorpusViewer: Don't Disable WebviewWidget for PyQt5#190

Merged
ajdapretnar merged 1 commit intobiolab:masterfrom
nikicc:corpus-viewer-enable-pyqt5
Feb 2, 2017
Merged

[FIX] CorpusViewer: Don't Disable WebviewWidget for PyQt5#190
ajdapretnar merged 1 commit intobiolab:masterfrom
nikicc:corpus-viewer-enable-pyqt5

Conversation

@nikicc
Copy link
Copy Markdown
Contributor

@nikicc nikicc commented Feb 2, 2017

Issue

In CorpusViewer scrolling didn't work on PyQt5.

Changes

Don't disable WebviewWidget when on PyQt5, since the issue will be solved in Orange. Blocked on biolab/orange3#1983.

@nikicc nikicc added this to the 0.2.3 milestone Feb 2, 2017
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 2, 2017

Codecov Report

Merging #190 into master will increase coverage by 0.38%.

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage      94%   94.38%   +0.38%     
==========================================
  Files          30       30              
  Lines        1567     1567              
  Branches      287      287              
==========================================
+ Hits         1473     1479       +6     
+ Misses         53       47       -6     
  Partials       41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021030b...34c6017. Read the comment docs.

@ajdapretnar ajdapretnar merged commit 00b2782 into biolab:master Feb 2, 2017
@nikicc nikicc deleted the corpus-viewer-enable-pyqt5 branch February 2, 2017 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants