Skip to content

Preprocess: Automated summaries compatibility#647

Merged
janezd merged 1 commit intobiolab:masterfrom
VesnaT:pp_summary_fix
Apr 16, 2021
Merged

Preprocess: Automated summaries compatibility#647
janezd merged 1 commit intobiolab:masterfrom
VesnaT:pp_summary_fix

Conversation

@VesnaT
Copy link
Copy Markdown
Contributor

@VesnaT VesnaT commented Apr 12, 2021

Issue

The Preprocess widget will start crashing once biolab/orange3#5308 is merged.

Includes
  • Code changes
  • Tests
  • Documentation

@janezd
Copy link
Copy Markdown
Contributor

janezd commented Apr 15, 2021

Auto summaries were broken (duplicated) because the widget hacks away the inherited signal by not deriving the class Inputs from base class' Inputs. Wouldn't this work (with also adding the declaration about signal renaming, for backward compatibility)?

     class Inputs(OWPreprocess.Inputs):
        data = Input("data", Corpus)

Or even, if muß es sein,

     class Inputs(OWPreprocess.Inputs):
        data = Input("corpus", Corpus)

With this, set_data will be able to call the inherited method~~, but auto summary will be called just once~~?

I just added a test; it is called twice, but sets the same thing. This is unwelcome, but shouldn't have any consequences. (I need to find a way to avoid this, though.)

@janezd
Copy link
Copy Markdown
Contributor

janezd commented Apr 16, 2021

I checked how signals are collected: without some overhaul there, I don't see a better solution than the one in this PR.

@janezd janezd merged commit 97e3a1b into biolab:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants