Preprocess: Automated summaries compatibility#647
Merged
janezd merged 1 commit intobiolab:masterfrom Apr 16, 2021
Merged
Conversation
Contributor
|
Auto summaries were broken (duplicated) because the widget hacks away the inherited signal by not deriving the class class Inputs(OWPreprocess.Inputs):
data = Input("data", Corpus)Or even, if muß es sein, class Inputs(OWPreprocess.Inputs):
data = Input("corpus", Corpus)With this, I just added a test; it is called twice, but sets the same thing. This is unwelcome, but shouldn't have any consequences. (I need to find a way to avoid this, though.) |
Contributor
|
I checked how signals are collected: without some overhaul there, I don't see a better solution than the one in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The Preprocess widget will start crashing once biolab/orange3#5308 is merged.
Includes