Parameter Fitter: Lint

Author: janezd

Orange/widgets/evaluate/owparameterfitter.py

@@ -274,7 +274,7 @@ def set_steps(self, steps: Optional[Sequence[int]]):
     def steps(self):
         return self.__steps
 
-    def paintEvent(self, event):
+    def paintEvent(self, _):
         if not self.__steps:
             return
         painter = QPainter(self)
@@ -346,11 +346,7 @@ def __init__(self):
         ConcurrentWidgetMixin.__init__(self)
         self._data: Optional[Table] = None
         self._learner: Optional[Learner] = None
-        self.graph: Optional[FitterPlot] = None
         self.__parameters_model = QStandardItemModel()
-        self.__combo: Optional[QComboBox] = None
-        self.__spin_min: Optional[QSpinBox] = None
-        self.__spin_max: Optional[QSpinBox] = None
 
         self.__pending_parameter_index = self.parameter_index \
             if self.parameter_index != self.DEFAULT_PARAMETER_INDEX else None
@@ -369,11 +365,15 @@ def setup_gui(self):
         self._add_controls()
 
     def _add_plot(self):
+        # This is a part of __init__
+        # pylint: disable=attribute-defined-outside-init
         box = gui.vBox(self.mainArea)
         self.graph = FitterPlot()
         box.layout().addWidget(self.graph)
 
     def _add_controls(self):
+        # This is a part of __init__
+        # pylint: disable=attribute-defined-outside-init
         layout = QGridLayout()
         gui.widgetBox(self.controlArea, "Settings", orientation=layout)
         self.__combo = gui.comboBox(None, self, "parameter_index",
@@ -386,6 +386,7 @@ def _add_controls(self):
         button = gui.appendRadioButton(buttons, "Range:")
         layout.addWidget(button, 1, 0)
 
+        # pylint: disable=use-dict-literal
         kw = dict(minv=-MIN_MAX_SPIN, maxv=MIN_MAX_SPIN,
                   alignment=Qt.AlignRight,
                   callback=self.__on_min_max_changed)
@@ -588,7 +589,7 @@ def _set_range_controls(self):
                 self.__spin_max.setMaximum(MIN_MAX_SPIN)
                 self.maximum = self.initial_parameters[param.name]
 
-        tip = f"Enter a list of comma-separated values"
+        tip = "Enter a list of comma-separated values"
         if param.min is not None:
             if param.max is not None:
                 self.edit.setToolTip(f"{tip} between {param.min} and {param.max}.")

Orange/widgets/evaluate/tests/test_owparameterfitter.py

@@ -260,13 +260,6 @@ def test_fitted_parameters(self):
         self.assertEqual(len(self.widget.fitted_parameters), 1)
         self.wait_until_finished()
 
-        # TODO: I would remove this test
-        # We may someday want to output a Learner from the widget
-        # I changed the widget so that it doesn't necessarily require data,
-        # so this test fails
-        # self.send_signal(self.widget.Inputs.data, None)
-        # self.assertEqual(self.widget.fitted_parameters, [])
-
     def test_initial_parameters(self):
         self.assertEqual(self.widget.initial_parameters, {})
 
@@ -390,13 +383,13 @@ def test_steps_from_range_error(self):
 
         w.minimum = 10
         w.maximum = 5
-        w.steps
+        w.steps  # pylint: disable=pointless-statement
         self.assertTrue(w.Error.min_max_error.is_shown())
 
         self.send_signal(w.Inputs.learner, None)
         self.assertFalse(w.Error.min_max_error.is_shown())
 
-    def test_steps_from_range_error(self):
+    def test_steps_from_ranges_steps(self):
         w: OWParameterFitter = self.widget
         self.send_signal(w.Inputs.data, self._heart)
         self.send_signal(w.Inputs.learner, self._dummy)
@@ -444,7 +437,7 @@ def test_steps_from_manual_error(self):
         self.assertFalse(w.Error.manual_steps_error.is_shown())
 
         w.manual_steps = "1, 2, 3, asdf, 4, 5"
-        w.steps
+        w.steps  # pylint: disable=pointless-statement
         self.assertTrue(w.Error.manual_steps_error.is_shown())
 
         self.send_signal(w.Inputs.learner, None)