[ENH] canvas: Indicate runtime state on links#1554
Conversation
Current coverage is 88.69% (diff: 100%)@@ master #1554 diff @@
==========================================
Files 78 78
Lines 8108 8108
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7191 7191
Misses 917 917
Partials 0 0
|
|
Have you considered switching the state that is shown on widgets? (Like highlighting the channels that do not pass any data)? |
BlazZupan
left a comment
BlazZupan
left a comment
There was a problem hiding this comment.
Very nice idea! I propose to mark the connections with no tokens (None) and leave all connections with tokens as they are (grey). Connection with no tokens can be shown as broken, the way we show now the connections that are disabled. For disabled connections use "a cut line" symbol: break connection in the middle and display the cut with two lines, something like ---//--- (except that the line is full and the only break really is between //)
* Disabled links are now displayed with a single disconnected symbol in the middle. * The dash line style is re-used for links with no data on them.
ales-erjavec
force-pushed
the
canvas/display-state
branch
from
0f2e705 to
996a236
Compare
astaric
left a comment
astaric
left a comment
There was a problem hiding this comment.
I like the way it looks now, and would really like to see this change merged.
ajdapretnar
left a comment
ajdapretnar
left a comment
There was a problem hiding this comment.
I like it too. Approve for Windows.
|
It looks great. |
janezd
changed the title
6 participants
Track and display the state of signal propagation on links in the canvas.