[FIX] Reporting tabular in Data Table and Rank widgets

[kernc]

QBrush. https://doc.qt.io/qt-4.8/qt.html#ItemDataRole-enum

Fixes report in Data Table.

[codecov-io]

Current coverage is 88.66% (diff: 100%)

Merging #1573 into master will not change coverage

@@             master      #1573   diff @@
==========================================
  Files            78         78          
  Lines          8124       8124          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           7203       7203          
  Misses          921        921          
  Partials          0          0          

Powered by Codecov. Last update f539789...20c6e1e

[ales-erjavec]

Ok. But I think you should still handle the case where the data(Qt.BackgroundRole) is not a QBrush in report_table, as there is no guaranty what the return value from QAbstractDataModel.data actually is. At the very least it needs to check for None values (i.e. an empty/null QVariant()).

[kernc]

In Qt, QBrush is always returned for this role. No guarantee, but a convention. If the user passes arbitrary types for predefined roles, that's a bug waiting to be discovered.

For user roles, it is up to the developer to decide which types to use and ensure that components use the correct types when accessing and setting data.

Emphasis added.

None case is handled.

[ales-erjavec]

• https://github.com/qt/qtxmlpatterns/blob/678502cce013a01a344e7a54d06bbf2aa816af13/tests/auto/xmlpatternssdk/TestGroup.cpp#L75
• https://github.com/qt/qtcharts/blob/4cbd063d221985f1d659b50f7353902a26bcfd7d/tests/manual/chartdesigner/engine.cpp#L175
• https://github.com/qt/qtcharts/blob/4cbd063d221985f1d659b50f7353902a26bcfd7d/examples/charts/barmodelmapper/customtablemodel.cpp#L91
• https://github.com/qt/qtcharts/blob/4cbd063d221985f1d659b50f7353902a26bcfd7d/examples/charts/modeldata/customtablemodel.cpp#L90
• https://github.com/qt/qtcharts/blob/facc2941efbfb8c9f40e363f0ea881653f6b4393/tests/manual/candlesticktester/customtablemodel.cpp
• https://github.com/qtproject/qt-creator/blob/7f8acd8fda7c831a4085c167c16a54cea4702fa2/src/plugins/texteditor/colorschemeedit.cpp#L103
• https://github.com/qtproject/qt-creator/blob/15fbfaf2e94b72cfd54bb0bd6f2b9ab87b870795/src/plugins/cppeditor/cppinsertvirtualmethods.cpp#L443

Really anything which is qvariant_cast<QBrush>() convertible can be a returned/set for a Qt::BackgroundRole as far as Qt is concerned. This includes QColor and even QPixmap.

It is an unfortunate consequence of PyQt QVariant api 2 that the abstraction that is provided by the QVariant is no longer available.

Note that qvariant_cast<T>() or one of the equivalent converters is the only way to get any value out of a QVariant, and that if passed a value it cannot convert it returns a default constructed T(). So you might say that graceful fallback when presented with arbitrary types in Qt item/model view framework is not only a convention but a rule.

None case is handled.

Sorry I did not see that.

[kernc]

Thanks for the elaborate response. Please find the PR completely revised.

[ajdapretnar]

Is this solving crash for Report? Because the fix works, but there's also the issue of this:

Also it makes reporting very slow. I don't remember how it was before, but it takes about 30s-1m to report on adult.tab (Win10).

[janezd]

Do not reformat the number here, at least not like this.

Orange used to keep track of the number of decimal places it should print for a specific variable. For instance, the "ST by exercise" has only a single decimal in the heart_disease.tab file, and the "age" and the "number of vessels colored" have none, obviously. Orange used to record this when loading the data. Now all numeric values have three decimals.

I consider this a bug (#1581). After this is fixed, model.data that is used in, say, the Table widget, will (again) show the numeric values with appropriate number of decimals, so this function should not reformat it.

[kernc]

Rebased and without the offending commit.