[FIX] Fix an error when using latest pyqtgraph develop snapshot#1662
[FIX] Fix an error when using latest pyqtgraph develop snapshot#1662lanzagar merged 2 commits intobiolab:masterfrom
Conversation
ales-erjavec
commented
Oct 14, 2016
- Fix an AttributeError when using latest pyqtgraph develop branch.
- Lock aspect ratio on the plot view.
Current coverage is 88.73% (diff: 100%)@@ master #1662 diff @@
==========================================
Files 78 78
Lines 8150 8150
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7232 7232
Misses 918 918
Partials 0 0
|
|
Looks OK. |
|
Yes labels and text would get misaligned, so locking the aspect fixes it. However biplots should/need to preserve aspect ratio (i.e. preserve angles). Note that MDS also uses locked aspect ratio (to preserve distances). So not all visualizations are consistent in this regard. Come to think of it, Correspondence Analysis might also need this (it is a form of a biplot). |
|
I agree that it should be locked here, let's do it in others as well (where needed). |