[FIX] Scatter Plot: Fix a error when restoring from pre DomainModel workflows#1672
Conversation
... when the attr_* were stored by name.
Current coverage is 89.38% (diff: 100%)@@ master #1672 diff @@
==========================================
Files 79 79
Lines 8589 8589
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7677 7677
Misses 912 912
Partials 0 0
|
|
I knew that #1608 breaks compatibility, but decided against introducing legacy patches. I changed my mind. I don't oppose to adding this PR. Yet this example shows we need a general solution. 7e454bd is going to create the same problem in Sieve. I suppose we need settings versions and a method |
janezd
left a comment
There was a problem hiding this comment.
Please wait with merging this; I will try to refactor it into a more general solution. Give me one day.
|
One day is gone. A general solution turned out to be more complicated. While it may come at a later time, I am merging this now as it fixes a known bug. |
The general solution turned out more complicated and will be done at a later date.
... when the attr_* were stored by name.
For example open the second workflow (Interactive Visualizations) in the 'MenuBar->Help->Examples'