[ENH] Canvas: Always show the link dialog if the user holds Shift#1673
Merged
lanzagar merged 1 commit intobiolab:masterfrom Oct 21, 2016
Merged
[ENH] Canvas: Always show the link dialog if the user holds Shift#1673lanzagar merged 1 commit intobiolab:masterfrom
lanzagar merged 1 commit intobiolab:masterfrom
Conversation
Current coverage is 89.38% (diff: 100%)@@ master #1673 diff @@
==========================================
Files 79 79
Lines 8593 8593
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7681 7681
Misses 912 912
Partials 0 0
|
Contributor
|
Please initialize the flag in the class You might also make it slightly less of an easter egg and mention this in the |
janezd
force-pushed
the
force-show-link-dlg
branch
from
680614a to
a6cb8f7
Compare
Contributor
Author
|
Done, I guess. Thanks for the tip about the tip! |
Contributor
|
The feature stops being an easter egg if you document it also in the user docs. |
ales-erjavec
approved these changes
Oct 21, 2016
lanzagar
approved these changes
Oct 21, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numerous widgets now provide the signal with annotated data (#1655), which will be used quite often, but it is not the default output. Selected data should stay the default; even always showing the dialog would be annoying. The user thus has to connect the widgets, double click the link, and reroute. This annoyed me a lot.
I suggest that holding shift while connecting should trigger opening the link dialog. To not confuse the user, this should happen even when there's just a single signal on both sides.
I know this feature is a bit of easter egg, but a really useful one.
@ales-erjavec, the change is really simple. Have I overlooked anything?