Merged
Conversation
Contributor
ales-erjavec
commented
Oct 28, 2016
ales-erjavec
commented
- Fix tests so they run with PyQt5, without sql backend and on Windows.
- Fix QtWebEngine availability test in canvasmain.py
Contributor
Author
|
These were originally part of #1693 |
Current coverage is 88.86% (diff: 100%)@@ master #1698 diff @@
==========================================
Files 82 82
Lines 8802 8802
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7822 7822
Misses 980 980
Partials 0 0
|
* Use full local file url (with file: schema).
On Qt5 QUrl("/abs/path") is not considered to be a local file
* Use `os.path.samepath` to check path equality (windows)
Avoid an "ARPACK error 3: No shifts could be applied ..." when running tests on Windows.
ales-erjavec
force-pushed
the
test-fixes
branch
from
345afad to
d78d5dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.