Skip to content

[FIX] DendrogramWidget: Prevent a zero division error#1725

Merged
janezd merged 2 commits intobiolab:masterfrom
ales-erjavec:fixes/hclust-zero-div
Nov 5, 2016
Merged

[FIX] DendrogramWidget: Prevent a zero division error#1725
janezd merged 2 commits intobiolab:masterfrom
ales-erjavec:fixes/hclust-zero-div

Conversation

@ales-erjavec
Copy link
Contributor

Issue
Description of changes
  • Prevent a ZeroDivisionError when the dendrogram has zero height.
  • Also remove a duplicated layout insertion.
Includes
  • Code changes
  • Tests
  • Documentation

The 'Selection' grid layout was inserted into the same parent layout
twice (causing a warning on stdout)
@codecov-io
Copy link

codecov-io commented Nov 4, 2016

Current coverage is 88.86% (diff: 100%)

Merging #1725 into master will not change coverage

@@             master      #1725   diff @@
==========================================
  Files            82         82          
  Lines          8804       8804          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           7824       7824          
  Misses          980        980          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update a53b8b4...23f1395

@janezd janezd merged commit 8673d52 into biolab:master Nov 5, 2016
@astaric astaric modified the milestone: 3.3.9 Nov 28, 2016
@ales-erjavec ales-erjavec deleted the fixes/hclust-zero-div branch January 27, 2017 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants