[FIX] canvas/toolgrid: Remove (unused) mouse press event tracking#1740
Merged
janezd merged 2 commits intobiolab:masterfrom Nov 11, 2016
Merged
[FIX] canvas/toolgrid: Remove (unused) mouse press event tracking#1740janezd merged 2 commits intobiolab:masterfrom
janezd merged 2 commits intobiolab:masterfrom
Conversation
Current coverage is 88.87% (diff: 100%)@@ master #1740 diff @@
==========================================
Files 82 82
Lines 8819 8819
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7838 7838
Misses 981 981
Partials 0 0
|
Fix an `AttributeError: 'NoneType' object has no attribute 'underMouse'` in the `ToolButtonEventListener.eventFilter`. The mouse press tracking was not even used so the class was removed, merging the parts that were used into `ToolGrid` itself.
ales-erjavec
force-pushed
the
canvas/toolgrid-fix
branch
from
163b5ab to
9625543
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Under some circumstances a MouseRelease event could be delivered without a preceding MousePress event causing a
AttributeError: 'NoneType' object has no attribute 'underMouse'in theToolButtonEventListener.eventFilterDescription of changes
Remove the
ToolButtonEventListeneraltogether as the mouse press tracking was not even used.Parts that were needed were merged into the
ToolGridclass itself.Includes