OWConfusionMatrix: Fix predicitons order#1751
Closed
nikicc wants to merge 1 commit intobiolab:masterfrom
Closed
Conversation
The order of predictions commign from `self.results.predicted` is different than the order of examples in data table. Hence, to append predictions to data table, the correct order must first be restored.
Contributor
Author
|
Tests seem to fail due to an unrelated issue with RandomForestRegression. |
Contributor
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
In confusion matrix, as of #1655 (commit deb8585), predictions were appended to the data in incorrect order. The core of the issue is due to the fact that
predictionsfromResults.predictedare not in the same order as instances in data table.For example, select only misclassified examples on iris and pass them to a table. Some of the misclassified examples have a predicted class that is the same as the correct one.
Description of changes
Predictions from
Results.predictedare first sorted into the order of data instances and only then appended.Includes