[FIX] Fix transformation for non primitive variables#1770
Merged
janezd merged 2 commits intobiolab:masterfrom Nov 22, 2016
Merged
[FIX] Fix transformation for non primitive variables#1770janezd merged 2 commits intobiolab:masterfrom
janezd merged 2 commits intobiolab:masterfrom
Conversation
Fix a 'TypeError: variables must be primitive' when a transformation is defined for a `StringVariable` (as is the case in 'Edit Domain' widget). This was broken since 959f696
Contributor
|
I fixed the same thing this weekend. :) See dbfa1e2. The fix is the same, but tests are different. You call an actual transformation and I use a mock and call |
Current coverage is 88.91% (diff: 100%)@@ master #1770 diff @@
==========================================
Files 82 82
Lines 8847 8853 +6
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 7866 7872 +6
Misses 981 981
Partials 0 0
|
transformation.Transformation: Fix for transformation of non-primitive attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When editing a StringVariable in "Edit Domain" widget an TypeError is raised:
Description of changes
Fix base Transformation class to handle the non primitive variable case.
Includes