Skip to content

[FIX] owsilhouetteplot: Fix TypeError when cluster column is an object array #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
astaric merged 1 commit into from
Jan 10, 2017
Merged

[FIX] owsilhouetteplot: Fix TypeError when cluster column is an object array #1876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Orange/widgets/visualize/owsilhouetteplot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ def _update(self):

labelvar = self.cluster_var_model[self.cluster_var_idx]
labels, _ = self.data.get_column_view(labelvar)
labels = numpy.asarray(labels, dtype=float)
mask = numpy.isnan(labels)
labels = labels.astype(int)
labels = labels[~mask]
Expand Down
12 changes: 12 additions & 0 deletions Orange/widgets/visualize/tests/test_owsilhouetteplot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import numpy as np

import Orange.data
from Orange.widgets.utils.annotated_data import ANNOTATED_DATA_SIGNAL_NAME
from Orange.widgets.visualize.owsilhouetteplot import OWSilhouettePlot
from Orange.widgets.tests.base import WidgetTest, WidgetOutputsTestMixin
Expand Down Expand Up @@ -72,3 +73,14 @@ def test_unknowns_in_labels(self):
self.assertTrue(np.all(np.isfinite(scores_1)))
# the scores must match
np.testing.assert_almost_equal(scores_1, scores[valid], decimal=12)

def test_meta_object_dtype(self):
# gh-1875: Test on mixed string/discrete metas
data = self.data[::5]
domain = Orange.data.Domain(
data.domain.attributes, [],
[data.domain["iris"],
Orange.data.StringVariable("S")]
)
data = data.from_table(domain, data)
self.send_signal("Data", data)