[FIX] MDS Widget: Handle NaN values for plot point styling#1931
Merged
lanzagar merged 2 commits intobiolab:masterfrom Jan 18, 2017
Merged
[FIX] MDS Widget: Handle NaN values for plot point styling#1931lanzagar merged 2 commits intobiolab:masterfrom
lanzagar merged 2 commits intobiolab:masterfrom
Conversation
Current coverage is 89.27% (diff: 100%)@@ master #1931 diff @@
==========================================
Files 86 86
Lines 9116 9116
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 8138 8138
Misses 978 978
Partials 0 0
|
lanzagar
reviewed
Jan 18, 2017
| size_data = column(self.data, size_var, dtype=float) | ||
| size_data = scale(size_data) | ||
| size_data = MinPointSize + size_data * point_size | ||
| size_data[numpy.isnan(size_data)] = 1 # maybe 0? |
Contributor
There was a problem hiding this comment.
How about MinPointSize (or equivalently 0, but one line higher)
Contributor
Author
There was a problem hiding this comment.
Would prefer to keep the points with unknown size visually distinguished from the rest (in some way)
Contributor
There was a problem hiding this comment.
OK, then the current value of 1 should be fine. It's already smaller than anything else.
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 18, 2017
[FIX] MDS Widget: Handle NaN values for plot point styling (cherry picked from commit 6661596)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes gh-1930
Description of changes
Make
_setup_plotmore robust for NaN values in the data.Includes