Merged
Conversation
Current coverage is 89.51% (diff: 100%)@@ master #1936 diff @@
==========================================
Files 90 90
Lines 9180 9182 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 8219 8219
- Misses 961 963 +2
Partials 0 0
|
lanzagar
requested changes
Jan 20, 2017
Contributor
lanzagar
left a comment
There was a problem hiding this comment.
A couple of suggestions:
- Some difference in the font for Points/Total/Probabilities vs. feature names would be very welcome. I think just changing feature names to not be bold would already make the visualization easier and quicker to process.
- Log. Reg. models always use
align left(setting disabled). And for Naive Bayes, center alignment will mostly be used. I suggest removing this setting completely, and just selecting this automatically based on the classifier. - I suggest removing the option
Variancein Sort by. Together with absolute importance they are a bit redundant, as the latter incorporates it to a degree anyway - a variable can't distinguish classes well without enough variance. Variance of a variable is also not readable from this visualization (unlike other measures) and should be investigated somewhere else (box plot?). - A better default would probably be to show the top 10 most informative variables (absolute importance). All and unsorted is probably going to be changed very quickly and every time for data with tens of variables or more.
- I was not yet able to figure out what the
Continuous features:option is used for? It is disabled for data with discrete and/or continuous features. TotalandProbabilitiesappear as separate graphical elements. IMHO it would be better to either:
a) Have them actually be separate. In this case Probabilities could be on a linear scale from 0 to 1. (points not aligned)
b) Use one line and one point, with values for Total/Prob. shown above/below.
c) Keep two separate scales, but make it more clear they are connected by a small vertical line going through both (aligned) points.
With b) and c) users are less likely to look only at Prob. (while changing feature sliders) and be confused by some peculiarities (like the cutoff and a deformed scale). Adding <= and >= to the first and last value could also help.
Contributor
Author
|
@janezd Could you please confirm the above suggestions? |
80abbf7 to
61de7e1
Compare
Contributor
|
We noticed some bugs with @VesnaT yesterday, which she began fixing. When she confirms that is finished I am in favour of merging, and doing improvements in new PRs afterwards. |
c505f78 to
77abd43
Compare
lanzagar
approved these changes
Jan 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes
Includes