[ENH] Widget testing utilities#1939
Conversation
ales-erjavec
force-pushed
the
fixes/linearprojection-nan-columns
branch
from
e675d5f to
f0ddfb0
Compare
Current coverage is 89.31% (diff: 100%)@@ master #1939 diff @@
==========================================
Files 86 86
Lines 9119 9119
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 8145 8145
Misses 974 974
Partials 0 0
|
Orange/widgets/tests/base.py
Outdated
| One discrete constant class D with NaN values. | ||
|
|
||
| Mixed continuous/discrete/string class metas ({X,D,S}M) | ||
| One discrete constant class (D) with NaN values |
Orange/widgets/tests/base.py
Outdated
| return os.path.join(dirname, filename) | ||
|
|
||
| @classmethod | ||
| def data_1(cls): |
There was a problem hiding this comment.
These methods could use more descriptive names. maybe missing_data_1? Telling what exactly is in the dataset would probably make them longer that 50 characters.
There was a problem hiding this comment.
I agree, but cant think of a naming scheme besides missing_data_{1,2,3}.
There was a problem hiding this comment.
So maybe just missing_data_n (with matching/modified filenames of the test files)?
I am afraid that otherwise the pattern will continue and we will get data_{4,5,6,7,8} in the future, making it impossible to tell what kind of data is used in the test.
Orange/widgets/tests/base.py
Outdated
| QApplication, QComboBox, QSpinBox, QDoubleSpinBox, QSlider | ||
| ) | ||
|
|
||
| import Orange.data |
There was a problem hiding this comment.
Table is already imported in the line 15. Maybe the rest of the symbols could be imported in the same fashion?
ales-erjavec
force-pushed
the
fixes/linearprojection-nan-columns
branch
4 times, most recently
from
77147bf to
92fe2fb
Compare
Fix an error when a column contains (all/some) NaN values. Fixes biolabgh-1938
ales-erjavec
force-pushed
the
fixes/linearprojection-nan-columns
branch
from
92fe2fb to
76814cd
Compare
…-columns [ENH] Widget testing utilities (cherry picked from commit 40c677d) Conflicts: MANIFEST.in Orange/widgets/tests/base.py
3 participants
Issue
Add some utilities for testing widgets, some datasets, ...
Also includes fix (and test) for gh-1938
Description of changes
Includes