[FIX] Python 3.6 compatibility#1963
Merged
lanzagar merged 2 commits intobiolab:masterfrom Jan 27, 2017
Merged
Conversation
On Python 3.6 `bytes(numpy.array([2]))` raises a
TypeError: only integer scalar arrays can be converted to a scalar index
... when running without ORANGE_DEPRECATIONS_ERROR env set.
Current coverage is 89.53% (diff: 100%)@@ master #1963 diff @@
==========================================
Files 90 90
Lines 9179 9179
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 8218 8218
Misses 961 961
Partials 0 0
|
astaric
pushed a commit
that referenced
this pull request
Feb 3, 2017
[FIX] Python 3.6 compatibility (cherry picked from commit 53b0321) Conflicts: Orange/tests/test_preprocess.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
On Python 3.6
bytes(numpy.array([1,2]))raises aDescription of changes
Fix this use in two places where sha1 digest of an array is requested, passing the array memory view directly to sha1 (if the arrays is c contiguous this also avoids a copy.
Includes