[FIX] Table: Ensure correct dtype in _compute_distributions#1969
Merged
janezd merged 1 commit intobiolab:masterfrom Feb 3, 2017
Merged
Conversation
Fix an 'ValueError: cannot convert float NaN to integer' in bincount when the column data comes from a object array and contains NaN values.
b81907b to
e5c1dc3
Compare
Current coverage is 89.53% (diff: 100%)@@ master #1969 diff @@
==========================================
Files 90 90
Lines 9180 9182 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 8219 8221 +2
Misses 961 961
Partials 0 0
|
astaric
pushed a commit
that referenced
this pull request
Feb 3, 2017
…ject-array [FIX] Table: Ensure correct dtype in `_compute_distributions` (cherry picked from commit e3e3650)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
results in
Description of changes
Ensure correct dtype in
_compute_distributionswhen the column data comes from the metas array.Includes