Test File: Disallow changing string columns to datetime#2120
Merged
lanzagar merged 1 commit intobiolab:masterfrom Mar 28, 2017
jerneju:owfile-test-datetime-option
Merged
Test File: Disallow changing string columns to datetime#2120lanzagar merged 1 commit intobiolab:masterfrom jerneju:owfile-test-datetime-option
lanzagar merged 1 commit intobiolab:masterfrom
jerneju:owfile-test-datetime-option
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2120 +/- ##
==========================================
+ Coverage 71.5% 71.55% +0.04%
==========================================
Files 318 318
Lines 54453 54472 +19
==========================================
+ Hits 38939 38979 +40
+ Misses 15514 15493 -21Continue to review full report at Codecov.
|
Contributor
Author
lanzagar
requested changes
Mar 21, 2017
Contributor
lanzagar
left a comment
lanzagar
left a comment
There was a problem hiding this comment.
It looks like you are only creating a temp dir to create a temp file inside. Instead, you could just directly create a file with NamedTemporaryFile (and delete it later with os.remove)
Datetime option only if numerical. Test only. GH-2050
lanzagar
approved these changes
Mar 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Datetime option only if numerical. Test only.
#2050
Description of changes
Includes