[FIX] Fitter: Change params uses default if None#2127
Merged
janezd merged 2 commits intobiolab:masterfrom Mar 27, 2017
Merged
Conversation
pavlin-policar
changed the title
pavlin-policar
force-pushed
the
fitter-change-kwargs-default-params
branch
from
414c29c to
f6695ca
Compare
Codecov Report
@@ Coverage Diff @@
## master #2127 +/- ##
==========================================
- Coverage 71.49% 71.48% -0.01%
==========================================
Files 318 318
Lines 54414 54405 -9
==========================================
- Hits 38902 38894 -8
+ Misses 15512 15511 -1Continue to review full report at Codecov.
|
lanzagar
reviewed
Mar 22, 2017
Orange/modelling/base.py
Outdated
| self.get_learner(self.CLASSIFICATION).supports_weights and | ||
| hasattr(self.get_learner(self.REGRESSION), 'supports_weights') | ||
| and self.get_learner(self.REGRESSION).supports_weights) | ||
| and self.get_learner(self.REGRESSION).supports_weights |
Contributor
There was a problem hiding this comment.
getattr(self.get_learner(self.CLASSIFICATION), 'supports_weights', False) and
getattr(self.get_learner(self.REGRESSION), 'supports_weights', False)
pavlin-policar
force-pushed
the
fitter-change-kwargs-default-params
branch
from
5bb6c1c to
417e550
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#2125 4
Includes