[ENH] Pythagorean tree: Make border scale invariant#2141
Merged
janezd merged 1 commit intobiolab:masterfrom Mar 31, 2017
Merged
[ENH] Pythagorean tree: Make border scale invariant#2141janezd merged 1 commit intobiolab:masterfrom
janezd merged 1 commit intobiolab:masterfrom
Conversation
pavlin-policar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When viewing larger trees, especially regression trees, the square borders would scale along with the zoom, and would appear almost invisible. On the other hand, zooming in close would make the border very bulky.
Description of changes
The border is now scale invariant.
Before (random forest on Boston housing prices dataset):
After:
Includes