Skip to content

[FIX] Test & Score: crashing prevented when learner disconnects #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lanzagar merged 1 commit into from
Apr 7, 2017
Merged

[FIX] Test & Score: crashing prevented when learner disconnects #2194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions Orange/widgets/evaluate/owtestlearners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,15 @@ def update_progress(finished):
else:
self.error()

self.puts_results(learners, results, class_var)

self.setStatusMessage("")

def puts_results(self, learners, results, class_var):
"""
Called by _update_results. This method prepares calculated results and
put them into self.learners.
"""
learner_key = {slot.learner: key for key, slot in self.learners.items()}
for learner, result in zip(learners, results.split_by_model()):
stats = None
Expand All @@ -483,11 +492,10 @@ def update_progress(finished):
else:
stats = [Try(lambda: score(result)) for score in scorers]
result = Try.Success(result)
key = learner_key[learner]
self.learners[key] = \
self.learners[key]._replace(results=result, stats=stats)

self.setStatusMessage("")
if learner in learner_key:
key = learner_key.get(learner)
self.learners[key] = \
self.learners[key]._replace(results=result, stats=stats)

def _update_header(self):
# Set the correct horizontal header labels on the results_model.
Expand Down