[FIX] Support Sparse Data in Domain Editor#2245
Merged
jerneju merged 4 commits intobiolab:masterfrom Apr 24, 2017
Merged
Conversation
e573b53 to
e734aa8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2245 +/- ##
==========================================
+ Coverage 72.37% 72.39% +0.01%
==========================================
Files 319 319
Lines 55014 55056 +42
==========================================
+ Hits 39819 39858 +39
- Misses 15195 15198 +3 |
jerneju
approved these changes
Apr 20, 2017
c54a56a to
35727c9
Compare
Contributor
|
Can you reduce complexity? |
35727c9 to
58909e4
Compare
2516b82 to
e4385c6
Compare
Contributor
|
jerneju
suggested changes
Apr 21, 2017
Contributor
jerneju
left a comment
There was a problem hiding this comment.
Open corpus file, then iris, and then again corpus.
e4385c6 to
7362c81
Compare
7362c81 to
d90f5a8
Compare
Contributor
Author
|
@jerneju should be fixed now, please check again. |
jerneju
approved these changes
Apr 24, 2017
Contributor
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2188.
Description of changes
Enhance
DomainEditor.get_domainto handle sparse data. Also instead of returning a list of columns' the method itself merges them to appropriateX,yandmetaarrays.Includes