[FIX] owtestlearners: Fix migration of old settings#2254
Merged
astaric merged 1 commit intobiolab:masterfrom May 3, 2017
Merged
[FIX] owtestlearners: Fix migration of old settings#2254astaric merged 1 commit intobiolab:masterfrom
astaric merged 1 commit intobiolab:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2254 +/- ##
=========================================
+ Coverage 72.49% 72.5% +<.01%
=========================================
Files 319 319
Lines 55210 55216 +6
=========================================
+ Hits 40024 40033 +9
+ Misses 15186 15183 -3 |
lanzagar
changed the title
jerneju
suggested changes
Apr 24, 2017
3 tasks
lanzagar
changed the title
Member
|
@jerneju can you check if the latest fix solves the problems you have encountered? If it does, please update your review accordingly. |
jerneju
approved these changes
May 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Old settings were not migrated correctly (
context_settingsmight not be saved/exist)Description of changes
Drop old/incompatible
context_settingsinstead of modifying them.Includes