[FIX] Paint Data: Save and load labels#2259
Merged
astaric merged 2 commits intobiolab:masterfrom Apr 26, 2017
jerneju:paintdata-save-labels
Merged
[FIX] Paint Data: Save and load labels#2259astaric merged 2 commits intobiolab:masterfrom jerneju:paintdata-save-labels
astaric merged 2 commits intobiolab:masterfrom
jerneju:paintdata-save-labels
Conversation
astaric
reviewed
Apr 24, 2017
Orange/widgets/data/owpaintdata.py
Outdated
| density = Setting(7) | ||
| #: current data array (shape=(N, 3)) as presented on the output | ||
| data = Setting(None, schema_only=True) | ||
| labels = Setting(None, schema_only=True) |
Member
There was a problem hiding this comment.
Why not Setting(["C1", "C2"], schema_only=True)?
Codecov Report
@@ Coverage Diff @@
## master #2259 +/- ##
=========================================
Coverage ? 72.47%
=========================================
Files ? 319
Lines ? 55130
Branches ? 0
=========================================
Hits ? 39958
Misses ? 15172
Partials ? 0 |
astaric
reviewed
Apr 24, 2017
Orange/widgets/data/owpaintdata.py
Outdated
|
|
||
| def _i(name, icon_path="icons/paintdata", | ||
| widg_path=os.path.dirname(os.path.abspath(__file__))): | ||
| def _ic(name, icon_path="icons/paintdata", |
Member
There was a problem hiding this comment.
_i was not a very good name and neither is _ic. what is wrong with _icon?
Member
|
Works perfectly. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
No extra labels are saved when class has more than two values.
Description of changes
Includes